Todd Lipcon has posted comments on this change.

Change subject: spark: support serializing authentication data to tasks
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6081/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

Line 57:   @throws(classOf[java.io.IOException])
> Spark doesn't always use Java serialization, so this is incorrect.  I think
I verified that this stuff works even when the Spark serializer is set to kryo. 
I think Kryo only takes effect on certain classes which are explicitly 
registered (or maybe it auto-detects classes which have special serialization 
like this one? who knows? magic!!!)

Anyway, even with the conf set to Kryo, I was able to run a Spark SQL query fine

But, Dan also doesn't like that serialization can now throw an exception, so 
I'm going to look into another way to handle this.


-- 
To view, visit http://gerrit.cloudera.org:8080/6081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7be2c72eb801c3ee10e576ce8705c3b5997dffd9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Chris George <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to