Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1899. Fix support for empty string keys ......................................................................
KUDU-1899. Fix support for empty string keys We've never prevented users from inserting a row with "" as a key. However, a faulty assertion in diskrowset.cc caused the tablet server to crash on flush in this case. This adds a new end-to-end test via the client which inserts, updates, and deletes a row with a "" key. It caused a crash prior to this patch. Change-Id: I779f25afe6d39d91067b1e7c1238797ec2ac0295 Reviewed-on: http://gerrit.cloudera.org:8080/6163 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <[email protected]> (cherry picked from commit c11a315e73a20211caf71f2b3797e71af8449af4) Reviewed-on: http://gerrit.cloudera.org:8080/6178 --- M src/kudu/client/client-test.cc M src/kudu/tablet/diskrowset.cc 2 files changed, 77 insertions(+), 2 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I779f25afe6d39d91067b1e7c1238797ec2ac0295 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: branch-1.2.x Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
