Todd Lipcon has posted comments on this change. Change subject: webserver: add X-Frame-Options header ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6215/3/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: Line 70: TAG_FLAG(webserver_x_frame_options, advanced); > Have a question not specific to the patch, wondering when a flag is tagged "advanced" doesn't actually affect anything at runtime, but it does place the flags into a different section of the auto-generated flag documentation. (Experimental and unsafe flags have the effect of having to be 'unlocked') -- To view, visit http://gerrit.cloudera.org:8080/6215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie43ec476712c2574a4dc746dae6218f0a4195e09 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
