Alexey Serbin has posted comments on this change. Change subject: KUDU-1897: disable Kerberos replay cache ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6254/2/src/kudu/rpc/rpc-negotiation-bench.cc File src/kudu/rpc/rpc-negotiation-bench.cc: PS2, Line 148: friend class ClientThread; : friend class ClientAsyncWorkload; It seems these declaration are not needed. PS2, Line 190: nit: off-by-one shift PS2, Line 198: authn_token = SignedTokenPB(); : security::TokenPB token; : token.set_expire_unix_epoch_seconds(WallTime_Now() + validity / 2); : token.mutable_authn()->set_username("client-token"); : ASSERT_TRUE(token.SerializeToString(authn_token->mutable_token_data())); : ASSERT_OK(token_signer.SignToken(&authn_token.get())); Consider replacing with: SignedTokenPB authn_token; ASSERT_OK(token_signer.GenerateAuthnToken("client-token", &authn_token)); -- To view, visit http://gerrit.cloudera.org:8080/6254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbce55a0b12682fdf69e7b2c361c6336495db64d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
