Todd Lipcon has posted comments on this change.

Change subject: KUDU-1897: disable Kerberos replay cache
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6254/2/src/kudu/rpc/rpc-negotiation-bench.cc
File src/kudu/rpc/rpc-negotiation-bench.cc:

PS2, Line 109:   // Setup the KDC once. InitKerberosForServer uses global 
state, so it's easier
             :   // not to create a new KDC for every test case.
             :   void SetUp() override {
I think this still sets it up for every test case, doesn't it? maybe use static 
void SetUpTestCase?


-- 
To view, visit http://gerrit.cloudera.org:8080/6254
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbce55a0b12682fdf69e7b2c361c6336495db64d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to