Todd Lipcon has posted comments on this change. Change subject: KUDU-1905 - Allow reinserts on pk only tables ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/6258/1//COMMIT_MSG Commit Message: PS1, Line 9: as has http://gerrit.cloudera.org:8080/#/c/6258/1/src/kudu/common/row_changelist.cc File src/kudu/common/row_changelist.cc: Line 163: // Note that REINSERTs might have empty changelists when reinserting a row on a tablet that should we just say is_update()? http://gerrit.cloudera.org:8080/#/c/6258/2/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: Line 237: // For "upsert PK only", we expect the row to keep its old value nit: missing word 'if' PS2, Line 242: c typo PS2, Line 406: enum TestOpSets { : ALL, : PK_ONLY : }; what about doing something like: vector<TestOpType> kAllOps = { TEST_INSERT, TEST_UPDATE, TEST_UPSERT, TEST_INSERT_PK_ONLY, ...} vector<TestOpType> kPkOnlyOps = { TEST_INSERT_PK_ONLY, ...} or somesuch? then the PickOpAtRandom can just pick a random one based on op_types.size() instead of the kind of funny "retry until we get one which matches" loop PS2, Line 446: case TEST_INSERT: : if (exists[row_key]) continue; : ops->push_back({TEST_INSERT, row_key}); : exists[row_key] = true; : ops_pending = true; : data_in_mrs = true; : break; : case TEST_INSERT_PK_ONLY: : if (exists[row_key]) continue; : ops->push_back({TEST_INSERT_PK_ONLY, row_key}); : exists[row_key] = true; : ops_pending = true; : data_in_mrs = true; : you can combine these two cases by doing ops->push_back({r, row_key}) right? -- To view, visit http://gerrit.cloudera.org:8080/6258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce03378c7b97fac8ad8cb7783dec4a1b0277344 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
