Adar Dembo has posted comments on this change. Change subject: env: Add support for getting FS capacity ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: Line 806: TEST_F(TestEnv, TestGetBytesFree) { Nit: maybe rename the test too? Line 814: NO_FATALS(AssertEventually([&] { I don't think AssertEventually() needs to be wrapped in NO_FATALS(). I've never seen that done before. http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1023: virtual Status GetSpaceInfo(const std::string& path, SpaceInfo* space_info) OVERRIDE { Nit: don't need std:: prefix. -- To view, visit http://gerrit.cloudera.org:8080/6255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id43275876d3352f5cf943e24ed4513b9f2c131aa Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
