Todd Lipcon has posted comments on this change. Change subject: env: Add support for getting FS capacity ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: Line 814: NO_FATALS(AssertEventually([&] { > isn't this a bug in AssertEventually then? assert is clearly expected to fa ASSERT only fails immediately if it's in the test method itself. Since AssertEventually is itself a function call, it can't 'return' from the test method. I suppose we could make it a macro that does NO_FATALS(AssertEventuallyInternal(...)) to accomplish this if you think that's better? -- To view, visit http://gerrit.cloudera.org:8080/6255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id43275876d3352f5cf943e24ed4513b9f2c131aa Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
