Mike Percy has posted comments on this change. Change subject: Ignore SIGPIPE earlier in startup process ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6262/1/src/kudu/util/logging.cc File src/kudu/util/logging.cc: Line 269: // Ignore SIGPIPE early in the startup process so that threads writing to TLS > Can you file a JIRA about this? Last night Todd mentioned that we can imple Filed KUDU-1910. However we use pipe() in subprocess.cc so there is an argument for keeping SIGPIPE ignored permanently. http://gerrit.cloudera.org:8080/#/c/6262/1/src/kudu/util/logging.h File src/kudu/util/logging.h: PS1, Line 262: SIG_IG > Nit: SIG_IGN, to be more precise. Done http://gerrit.cloudera.org:8080/#/c/6262/1/src/kudu/util/signal.cc File src/kudu/util/signal.cc: PS1, Line 38: } : > Yeah I did just move this code... I assumed it's to avoid a syscall when we I think I have a solution involving blocking SIGPIPE from particular threads, but I'll leave that as a follow-up patch. http://gerrit.cloudera.org:8080/#/c/6262/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 76: #else > Is this still needed? Done -- To view, visit http://gerrit.cloudera.org:8080/6262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I040bd38ff31451ed9e25e7cf2127c869cf08a628 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
