Todd Lipcon has posted comments on this change.

Change subject: Ignore SIGPIPE earlier in startup process
......................................................................


Patch Set 1:

(1 comment)

What's the plan for the client?

http://gerrit.cloudera.org:8080/#/c/6262/1/src/kudu/util/signal.cc
File src/kudu/util/signal.cc:

PS1, Line 38:   static GoogleOnceType once = GOOGLE_ONCE_INIT;
            :   GoogleOnceInit(&once, &IgnoreSigPipe);
I think you just moved this code, but actually curious why we bother using a 
ONCE here. it's not harmful to set twice


-- 
To view, visit http://gerrit.cloudera.org:8080/6262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I040bd38ff31451ed9e25e7cf2127c869cf08a628
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to