Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6269
Change subject: KUDU-1905 - Allow reinserts on pk only tables ...................................................................... KUDU-1905 - Allow reinserts on pk only tables Doing a reinsert to a table that has only primary key columns results in an empty change list. We're currently crashing whenever we see a empty changelist that is not a delete. The fix is just to allow empty changelists for reinserts. This also adds a new flavor of fuzz tests to fuzz-itest.cc that only have pk-only operations, as well as a directed regression test that would trigger the problem deterministically. Ran fuzz-itest in dist-tests with the new tests and the following command: KUDU_ALLOW_SLOW_TESTS=1 build-support/dist_test.py --collect-tmpdir \ loop -n 1000 build/debug/bin/fuzz-itest --gtest_repeat=10 \ --gtest_break_on_failure Tests passed 1000/1000. Results: http://dist-test.cloudera.org//job?job_id=david.alves.1488580839.22665 Change-Id: I7ce03378c7b97fac8ad8cb7783dec4a1b0277344 Reviewed-on: http://gerrit.cloudera.org:8080/6258 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> (cherry picked from commit fff5cbda80b6cc2016c4bce012d2e183d3c3e2bb) --- M src/kudu/common/row_changelist-test.cc M src/kudu/common/row_changelist.cc M src/kudu/integration-tests/fuzz-itest.cc 3 files changed, 118 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/6269/1 -- To view, visit http://gerrit.cloudera.org:8080/6269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ce03378c7b97fac8ad8cb7783dec4a1b0277344 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
