David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6170/10//COMMIT_MSG Commit Message: PS10, Line 11: nit extra space PS10, Line 14: same http://gerrit.cloudera.org:8080/#/c/6170/10/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: PS10, Line 627: const Status s = SyncWrite(&req, &resp); : if (!s.ok() && error_is_not_leader != nullptr) { : *error_is_not_leader = : (resp.has_error() && : resp.error().code() == TabletServerErrorPB::NOT_THE_LEADER); : } is this tested somewhere? I don't think we actually set this error code in the write path, this makes me nervous cuz it seems like this whole patch is lacking coverage. Am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
