Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 11: (2 comments) Added ./bin/catalog_manager_tsk-itest http://gerrit.cloudera.org:8080/#/c/6170/11/src/kudu/master/sys_catalog-test.cc File src/kudu/master/sys_catalog-test.cc: PS11, Line 425: EXPECT_EQ > why the change to EXPECT? Because this is not crucial for the following code (which is none), so it's EXPECT_EQ() is enough. If you mean it ASSERT_EQ() is good as well, so less unrelated changes -- I'll return it back. http://gerrit.cloudera.org:8080/#/c/6170/11/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 76: using kudu::tserver::TabletServerErrorPB; > warning: using decl 'TabletServerErrorPB' is unused [misc-unused-using-decl Done -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
