David Ribeiro Alves has posted comments on this change. Change subject: Make ExternalDaemon::StartProcess() handle fault injection ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6211/6/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 436: // Starts a process with the given flags. > is retrying multiple times the best way to go? or should we just return "OK hum, some tests might be expecting a running server after calling this, but you're right in that likely its those tests that should be fixed. done Line 438: > we can get rid of the SIGPIPE case with Mike's patch, right? k. feel kinda nervous allowing it to crash without knowing whether it has a fault flag, but I see your point. done -- To view, visit http://gerrit.cloudera.org:8080/6211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6046e34a321de3e324e20e3d63249e4073712447 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
