Todd Lipcon has posted comments on this change. Change subject: Make ExternalDaemon::StartProcess() handle fault injection ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6211/6/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 436: // If HasFaultFlags() is true, tries to start the process multiple times if TryStartProcess() is retrying multiple times the best way to go? or should we just return "OK"? I can see some tests are expecting to trigger exactly one crash rather than potentially restarting multiple times. Line 438: // a expected exit code OR that it received a SIGPIPE. we can get rid of the SIGPIPE case with Mike's patch, right? And given that we now only have to worry about the explicit fault injection crash, which has a recognizable error code, perhaps we should just do it all the time rather than trying to look at the flags? -- To view, visit http://gerrit.cloudera.org:8080/6211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6046e34a321de3e324e20e3d63249e4073712447 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
