Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6321
to review the following change.
Change subject: WIP: java: more error message cleanup
......................................................................
WIP: java: more error message cleanup
* Negotiator now throws a NonRecoverable KuduException when negotiation
fails
* Added stack trace truncation to a bunch of places where we know the
stack traces to be useless (eg when we're throwing an exception in a
stack called by Netty such as an event handler).
* Changed the Negotiator 'initial response' to be generated at the point
at which it is picking a SASL mechanism. This way it properly avoids
picking a mechanism that can't be intialized.
* When the Negotiation fails, fails the outbound RPCs on that connection
with a status indicating the negotiation failure instead of
"disconnected".
WIP because I'm not sure that "non-recoverable" exceptions are the right
approach here -- if we have some attempt of a read/write at a tablet
server, and negotiation fails on that tserver, we still want to retry
elsewhere in most cases. This may be too risky for 1.3 (maybe can pull
out some of the safer bits)
Change-Id: I50a254561b431b103caec1eff9f92c9705d78aef
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
5 files changed, 112 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/6321/1
--
To view, visit http://gerrit.cloudera.org:8080/6321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50a254561b431b103caec1eff9f92c9705d78aef
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
