Todd Lipcon has posted comments on this change. Change subject: fs: add BlockManager::GetAllBlockIds() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6360/1/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 247: virtual Status GetAllBlockIds(std::vector<BlockId>* block_ids) = 0; can you add some note about the behavior this has with "in-flight" blocks? or an admonishment not to use it on a block manager under concurrent use? -- To view, visit http://gerrit.cloudera.org:8080/6360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20e8ccf6e8a2deba88fcf5598fb404a1186b8262 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
