Todd Lipcon has posted comments on this change. Change subject: compaction-test: use default bloom sizing ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: PS2, Line 492: EXPECT_EQ(R"(RowIdxInBlock: 0; Base: (string key="hello 00017150", int32 val=1715, )" : "int32 nullable_val=NULL); Undo Mutations: [@1716(DELETE)]; Redo Mutations: [];", : rows[0]); : EXPECT_EQ(R"(RowIdxInBlock: 1; Base: (string key="hello 00017160", int32 val=1716, )" : "int32 nullable_val=1716); Undo Mutations: [@1717(DELETE)]; Redo Mutations: [];", : rows[1]); > Can we compute the expected strings instead of hardcoding them? With different bloom sizing, the rolling writer rolled at slightly different times (more smaller bloom blocks = more index overhead in the files, plus a lower FP rate = more bits/entry, etc, triggering a roll earlier). I don't think there's any real way to avoid hardcoding these, since the number of variables is very large. http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: PS2, Line 393: static BloomFilterSizing DefaultBloomSizing(); > docs Done -- To view, visit http://gerrit.cloudera.org:8080/6429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
