David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS9, Line 88: "Number of operations this server is behind the leader in appending " : "to the WAL." nit: in a comment in a previous ref I had mentioned to fix the "WAL" references there and elsewhere. here's one of the "elsewhere" :) PS9, Line 869: // Include a metric to indicate how far behind the highest peer's commit index : // this peer is. This is also added to the leader, as the leader may fall behind. wait, where does the commit index come into play? I would just remove this comment, since UpdateLagMetrics is already commented. http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: PS9, Line 246: // Called by the concensus implementation to update the lag metrics : // before preparing and applying the contents of a request. Also updates the : // queue state's 'last_index_appended_by_leader'. I don't think that you need to refer to where this is called from. How about: Updates the last op appended to the leader and the corresponding lag metric, which measures how many ops behind the leader the local replica is (0 if leader). Then you can remove comments on the call sites unless they have more information than the above PS9, Line 338: is nit: comma or period. i.e. "is, as" or "is. This is a soft..." -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
