Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS9, Line 88: "Number of operations this server is behind the leader in appending " : "to the WAL." > nit: in a comment in a previous ref I had mentioned to fix the "WAL" refere Done PS9, Line 869: queue_state_.last_appended.index() - queue_state_.committed_index); : > wait, where does the commit index come into play? I would just remove this Good catch. Done http://gerrit.cloudera.org:8080/#/c/6451/9/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: PS9, Line 246: // Called by the concensus implementation to update the lag metrics : // before preparing and applying the contents of a request. Also updates the : // queue state's 'last_index_appended_by_leader'. > I don't think that you need to refer to where this is called from. How abou Fair point. It's not very ubiquitous so it's less necessary to describe the call sites. I think call sites in test are valuable since the contextualize calling a bit, particularly when the tests don't have a leader/follower. PS9, Line 338: is > nit: comma or period. i.e. "is, as" or "is. This is a soft..." Done -- To view, visit http://gerrit.cloudera.org:8080/6451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8e992cc2397ca8d5873e62961a65f618d52c36 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
