Todd Lipcon has posted comments on this change. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6467/1/src/kudu/cfile/cfile_writer.h File src/kudu/cfile/cfile_writer.h: Line 21: #include <stdint.h> > Nit: can use <cstdint> if you want all C++-style inclusions. meh, don't want to scope-creep -- To view, visit http://gerrit.cloudera.org:8080/6467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5c8da82806404ce3c10463c86c7279ee6d37e69 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
