Todd Lipcon has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6470/1/src/kudu/tablet/rowset_metadata.h File src/kudu/tablet/rowset_metadata.h: Line 68: typedef boost::container::flat_map<ColumnId, BlockId> ColumnIdToBlockIdMap; > Nit: add a comment so no one accidentally replaces this with std::map. Done Line 102: void SetColumnDataBlocks(const std::map<ColumnId, BlockId>& blocks_by_col_id); > warning: function 'kudu::tablet::RowSetMetadata::SetColumnDataBlocks' has a Done -- To view, visit http://gerrit.cloudera.org:8080/6470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b7eaac3481672c69709009b6eacc2008027d4cd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
