Todd Lipcon has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map ......................................................................
Patch Set 4: (1 comment) looks like using the GNUC macro wasn't useful because clang can still be using libstdcxx... just switching to boost entirely, since boost should have the right fallback depending on the compiler version http://gerrit.cloudera.org:8080/#/c/6471/3/thirdparty/patches/sparsehash-0001-Add-compatibily-for-gcc-4.x-in-traits.patch File thirdparty/patches/sparsehash-0001-Add-compatibily-for-gcc-4.x-in-traits.patch: PS3, Line 47: struct is_relocatable<const T> : is_relocatable<T> {}; : -} : \ No newline at end of file : +} : -- : 2.7.4 : > Couldn't help yourself? :) my emacs couldn't help itself -- To view, visit http://gerrit.cloudera.org:8080/6471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e75deba7f7fb8d4f800695f195304df603e4ce9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
