Todd Lipcon has posted comments on this change. Change subject: interval_tree: improve an O(n) loop to O(lg n) ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6496/1/src/kudu/util/interval_tree-inl.h File src/kudu/util/interval_tree-inl.h: PS1, Line 231: results->insert(results->end(), overlapping_by_asc_left_.cbegin(), p); > please add a small comment indicating that the first half of the partition Done PS1, Line 268: overlapping_by_asc_left_.cbegin() > nit: The formatting of the arguments to partition_point is inconsistent bet Done -- To view, visit http://gerrit.cloudera.org:8080/6496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c9463fb901b7bf75d32b00cb528e96c119101e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
