Todd Lipcon has posted comments on this change. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6552/1//COMMIT_MSG Commit Message: PS1, Line 19: apparently : improved in OpenSSL 1.1, but that's not available on current OSes > Just passing through, but could we condition the behavior on the version of seems like extra complexity because then we have two different code paths to test. Also no supported operating systems are actually shipping 1.1 yet. -- To view, visit http://gerrit.cloudera.org:8080/6552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b4421f4aae4d0e5a2d938881f9eea4e07ff2b10 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
