Todd Lipcon has posted comments on this change. Change subject: KUDU-1964. security: avoid calling ERR_clear_error() defensively ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6552/3/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: PS3, Line 114: Status::RuntimeError( > Would it make sense to add GetOpenSSLErrors() here as well to clean up the Done http://gerrit.cloudera.org:8080/#/c/6552/3/src/kudu/security/openssl_util.h File src/kudu/security/openssl_util.h: PS3, Line 67: kudu::security::internal::ScopedCheckNoPendingSSLErrors _no_ssl_errors(__PRETTY_FUNCTION__) > nit: would it make sense to put this under constructing the empty/unused object on the stack should already optimize itself out -- To view, visit http://gerrit.cloudera.org:8080/6552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b4421f4aae4d0e5a2d938881f9eea4e07ff2b10 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
