Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5775/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 2191: > not necessarily? Done http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/partitioner-internal.cc File src/kudu/client/partitioner-internal.cc: Line 25: #include "kudu/client/client.h" > warning: #includes are not sorted properly [llvm-include-order] Done Line 33: using std::map; > warning: using decl 'map' is unused [misc-unused-using-decls] Done Line 70: ret_data->table_ = std::move(table_); > warning: std::move of the const expression has no effect; remove std::move( Done http://gerrit.cloudera.org:8080/#/c/5775/2/src/kudu/client/partitioner-internal.h File src/kudu/client/partitioner-internal.h: Line 23: #include <string> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/5775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08a078c75f15ef4200219b5260cfb99d79b72cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
