Dan Burkert has posted comments on this change. Change subject: Add 'ksck tserver list' tool ......................................................................
Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/6654/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: Line 86: using client::KuduClient; > warning: using decl 'KuduClient' is unused [misc-unused-using-decls] Done Line 396: cout << setfill('-') << setw(widths[col] + 2) << ""; > error: use of undeclared identifier 'setfill'; did you mean 'std::setfill'? Done Line 434: void PrintTable(vector<vector<string>> columns, string separator) { > warning: the parameter 'separator' is copied for each invocation but only u Done Line 449: Status PrintTable(vector<string> headers, vector<vector<string>> columns) { > warning: the parameter 'headers' is copied for each invocation but only use Done Line 449: Status PrintTable(vector<string> headers, vector<vector<string>> columns) { > warning: the parameter 'columns' is copied for each invocation but only use Done http://gerrit.cloudera.org:8080/#/c/6654/1/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: Line 21: #include <memory> > warning: #includes are not sorted properly [llvm-include-order] Done Line 55: using client::KuduClient; > warning: using decl 'KuduClient' is unused [misc-unused-using-decls] Done Line 56: using client::sp::shared_ptr; > warning: using decl 'shared_ptr' is unused [misc-unused-using-decls] Done Line 60: using rpc::RpcController; > warning: using decl 'RpcController' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/6654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047a7675c186a02dd5d8b405431ae885159fcfee Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
