Todd Lipcon has posted comments on this change. Change subject: Add 'ksck tserver list' tool ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6654/4//COMMIT_MSG Commit Message: Line 7: Add 'ksck tserver list' tool you mean 'kudu tserver list'? http://gerrit.cloudera.org:8080/#/c/6654/4/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: Line 405: for (int col = 0; col < num_columns; col++) { nit: indentation PS4, Line 407: size_t padding = value.size() - widths[col]; : cout << " " << value; : if (col != num_columns - 1) cout << setw(padding) << " |"; nit: might make more sense to put the definition of 'padding' inside of the body of the if() and use {} Line 416: void JsonPrintTable(const vector<string>& headers, const vector<vector<string>>& columns) { > Why not use JsonWriter? I think that's way less error prone than rolling yo +1 -- To view, visit http://gerrit.cloudera.org:8080/6654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047a7675c186a02dd5d8b405431ae885159fcfee Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
