David Ribeiro Alves has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results ......................................................................
Patch Set 5: (2 comments) MJ: Still need to address some comments, but included the client-side fix for the pointer re-writing. http://gerrit.cloudera.org:8080/#/c/6623/4/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: PS4, Line 487: if (pad_unixtime_micros_for_impala) { > ...and the logic below I was actually planning to do this on the next patch up, since this is client side, but maybe it makes more sense to have it here. I'll move it. PS4, Line 691: fa > good catch, agree we need to zero the columns in the case of nulls too. We're doing that below, right? if padding is not 0 or if there are nullable cols we memset the whole thing (that's what the benchmarks on the commit message refer to) -- To view, visit http://gerrit.cloudera.org:8080/6623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
