David Ribeiro Alves has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6623/4/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: PS4, Line 691: has_nullable_cols > Right, but has_nullable_cols only gets set within this if block, which is p ah, you're right. indeed good catch. thanks http://gerrit.cloudera.org:8080/#/c/6623/6/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: Line 479: // change any indirect data pointers back to "real" pointers instead of > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/6623/6/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: Line 127: void SerializeRowBlock(const RowBlock& block, RowwiseRowBlockPB* rowblock_pb, > warning: function 'kudu::SerializeRowBlock' has a definition with different Done -- To view, visit http://gerrit.cloudera.org:8080/6623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
