Todd Lipcon has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers ......................................................................
Patch Set 7: > If we're considering just unpunched holes, then yes. But, if the container > also has space beyond the file size (i.e. both unpunched holes and extra > preallocated space), then we don't know to which inconsistency to attribute > the excess. Sure, but if we assume that inconsistencies at all are the exception rather than the rule, then we can use the stat check as a first pass, and the only if we see a discrepancy, fall back to the more expensive GetExtentMap path? Also, do we care other than satisfying our curiosity? -- To view, visit http://gerrit.cloudera.org:8080/6585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
