Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6630/6/src/kudu/util/env.h File src/kudu/util/env.h: Line 21: #include <sys/uio.h> Would prefer not to leak this sort of platform-specific thing outside of env_posix.cc. An iovec is a pretty simple structure; perhaps you can define a Kudu version and adapt it to/from an iovec inside env_posix.cc? Line 390: virtual Status ReadV(uint64_t offset, Slice** results, Would std::vector<Slice>* be more intuitive for 'results'? That is, ReadV() takes a caller-provided vector of Slices and replaces its contents with a couple Slices of its own creation? Might be interesting to combine 'scratches' and 'results' into the same structure, since I imagine the length of the two must be the same. -- To view, visit http://gerrit.cloudera.org:8080/6630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6756834cd7f27af258797a3654a95244abeb0976 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
