Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 262: gscoped_ptr<uint8_t[]> scratch1(new uint8_t[size1]); > I mainly just followed the "pattern" from a few lines above. Happy to chang Yeah, we should be using unique_ptr in new sites. Not sure why I used heap allocation above, but that can change too. http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 174: // Simulates Linux's preadv API on OS X. BTW, I just noticed that we simulate pwritev() inline, in DoWriteV(). If you're feeling generous perhaps you can pull that out into this area too, so the two simulated functions can be defined side by side? Line 334: virtual Status ReadV(uint64_t offset, vector<ReadResult> results) const OVERRIDE { > It doesn't look like any read or write calls have this now. Since these are Hmm you're probably right; I didn't realize there weren't any calls in Write either. Nevermind then. -- To view, visit http://gerrit.cloudera.org:8080/6630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6756834cd7f27af258797a3654a95244abeb0976 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
