Adar Dembo has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning in concurrent_btree.h ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6693/2/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: Line 62: #pragma clang diagnostic push Unfortunately, gcc emits a warning on all "#pragma clang ..." I believe. Here's gcc 4.9.2: /data/jenkins/workspace/generic-package-centos64-7-0-impala/topdir/BUILD/kudu-1.4.0-cdh5.12.0-SNAPSHOT/src/kudu/consensus/consensus_peers.cc:46:0: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] #pragma clang diagnostic ignored "-Wc++14-extensions" ^ I'm not sure whether there's any way to fix that. Maybe you can do first #pragma GCC diagnostic ignored "-Wpragmas"? Would that work? Also, doesn't this need a corresponding #pragma clang diagnostic pop? -- To view, visit http://gerrit.cloudera.org:8080/6693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03518bcca43ea6c891a7f622972465c1ea87ce63 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
