Todd Lipcon has posted comments on this change. Change subject: Silence clang -Waddress-of-packed-member warning ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6693/1/CMakeLists.txt File CMakeLists.txt: Line 249: # Avoid 'taking address of packed member' warnings, which pollute macOs builds. worth saying "clang 4.0" since I actually noticed this when I tried using 4.0 on my linux box too. Line 252: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-address-of-packed-member") should we set this only on concurrent_btree.h with a #pragma push? maybe in general it's a good idea? (the cbtree is rather x86-specific anyway in other ways) -- To view, visit http://gerrit.cloudera.org:8080/6693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03518bcca43ea6c891a7f622972465c1ea87ce63 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
