Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6640/6/src/kudu/integration-tests/security-unknown-tsk-itest.cc File src/kudu/integration-tests/security-unknown-tsk-itest.cc: Line 175: for (int i = 0; i < num_tablet_servers_; ++i) { > This isn't quite accurate - the master will return more tablets than reques OK. Anyway, having several tablet servers to send requests to gives a better coverage, IMO. :) Line 217: SleepFor(MonoDelta::FromMilliseconds(2 * FLAGS_rpc_default_keepalive_time_ms)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done Line 279: atomic<bool> importer_do_run(true); > ah, so it's just a short-circuit? Yup. I updated the misleading comment. -- To view, visit http://gerrit.cloudera.org:8080/6640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
