Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/6640/10/src/kudu/integration-tests/security-unknown-tsk-itest.cc File src/kudu/integration-tests/security-unknown-tsk-itest.cc: Line 164: void ReplaceAuthnToken(shared_ptr<KuduClient> client, > warning: the parameter 'client' is copied for each invocation but only used Done Line 164: void ReplaceAuthnToken(shared_ptr<KuduClient> client, > Pass a KuduClient*. Good idea -- for some reason I didn't come up with that simple solution. PS10, Line 320: cutsom > typo Done Line 328: auto importer_cleanup = MakeScopedCleanup([&]() { > Is this join necessary? It's necessary if we are about to gracefully complete the test if something goes wrong in the code below. Otherwise it would be a mess during the destruction of the tread if the thread were not joined by the time of destruction. I saw several cases like that in other tests. -- To view, visit http://gerrit.cloudera.org:8080/6640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
