Mike Percy has posted comments on this change. Change subject: docs: Add breakpad documentation to user guide ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6504/2/docs/troubleshooting.adoc File docs/troubleshooting.adoc: Line 147: > Does it make sense to add information about enabling/disabling minidumps us I am not sure why people will want to disable it, so that's why I removed that from the doc. It is enabled by default on Linux, which is the only platform that it's supported on. PS2, Line 148: glog > nit: why not just 'log' ? To avoid confusion with the WAL PS2, Line 155: so : are not usable without access to the exact binary that crashed, or a very : similar binary. > I might be missing context wrt how minidumps are used. Is this referring to Without the binary, you can't use the minidump. For example, you can't print stack trace from the minidump without also having the binary. Think of it like a core file in that regard. I am glossing over the fact that if the symbols are extracted from the binary then there are things you can do with the minidump without the binary, since that is a low level detail that doesn't really seem relevant to users. PS2, Line 162: Note that while a minidump does not contain a : heap memory dump, it does contain stack memory and therefore it is possible for : application-specific information to appear in a minidump. > move this to a NOTE: section (adoc has special syntax for it). Done -- To view, visit http://gerrit.cloudera.org:8080/6504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
