Todd Lipcon has posted comments on this change.

Change subject: docs: Add breakpad documentation to user guide
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6504/1/docs/minidumps.adoc
File docs/minidumps.adoc:

PS1, Line 34: To disable minidump generation, set the
            : `--enable_minidumps` flag to `false`. 
why would a user want to disable it?


Line 64: Kudu developers have access to the minidump tools in their development
I think this developer-facing doc should be moved to different docs folder and 
keep this doc with just user-facing info on what minidumps are and where to 
send them.


Line 100: == Dumping the minidump stack trace to a text file (TODO)
TODO?


http://gerrit.cloudera.org:8080/#/c/6504/1/docs/support/jekyll-templates/document.html.erb
File docs/support/jekyll-templates/document.html.erb:

Line 101:         :minidumps, "Debugging with minidumps",
maybe this belongs under Troubleshooting?

"Debugging" also sounds like we're expecting users to debug kudu. Perhaps 
better to call it "Reporting Kudu crashes" or something?


-- 
To view, visit http://gerrit.cloudera.org:8080/6504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to