Adar Dembo has posted comments on this change. Change subject: env: add ReadV() API ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6779/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 312: Status DoReadV(int fd, const string& filename, uint64_t offset, vector<Slice>* results) { > Yeah, thats a good idea. I think I can convert to an iov and use/adjust it Right, you'll need to either consume an entire iov by shifting the iov array base/iov array size, or consume it partially by shifting iov.base/iov.size. I omitted the second part because I figured it's not new; it's equivalent to the next_result Slice arithmetic you're already doing (as you pointed out). -- To view, visit http://gerrit.cloudera.org:8080/6779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f7a62c8363b40baa064d9e63be1ece506f1e48 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
