Adar Dembo has posted comments on this change. Change subject: env: add ReadV() API ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6779/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 330: Slice result = results->at(i); You can also do: Slice& result = results[i]; Probably more idiomatic that way. Line 335: uint64_t completed_iov = 0; This could be an int (or size_t), since it's just the number of iovs. Or will that mess with the "iov + completed_iov" arithmetic? Line 363: for (size_t i = completed_iov; i < iov_size; i++) { Just to be safe, your injected short read test covers both of these cases, right? -- To view, visit http://gerrit.cloudera.org:8080/6779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f7a62c8363b40baa064d9e63be1ece506f1e48 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
