David Ribeiro Alves has posted comments on this change. Change subject: Expose row format flags in KuduScanner ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6624/7/src/kudu/integration-tests/all_types-itest.cc File src/kudu/integration-tests/all_types-itest.cc: Line 410: Status VerifyRows(ScannerSetup scanner_setup, RowVerifier verifier) { > warning: the parameter 'scanner_setup' is copied for each invocation but on Done Line 410: Status VerifyRows(ScannerSetup scanner_setup, RowVerifier verifier) { > warning: the parameter 'verifier' is copied for each invocation but only us Done Line 450: void RunTest(ScannerSetup scanner_setup, RowVerifier verifier) { > warning: the parameter 'scanner_setup' is copied for each invocation but on Done Line 450: void RunTest(ScannerSetup scanner_setup, RowVerifier verifier) { > warning: the parameter 'verifier' is copied for each invocation but only us Done http://gerrit.cloudera.org:8080/#/c/6624/7/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 348: virtual void set_row_format_flags(int64_t row_format_flags) {} > warning: parameter 'row_format_flags' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
