Todd Lipcon has posted comments on this change. Change subject: Expose row format flags in KuduScanner ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6624/9/src/kudu/client/client.h File src/kudu/client/client.h: PS9, Line 2032: bit set nit: I think 'bitset' is easier to understand Line 2046: /// format and the default will be used. add a note that some flags may require server-side support, and thus the caller should be prepared to handle a NotSupported status in Open() and NextBatch()? -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
