David Ribeiro Alves has submitted this change and it was merged. Change subject: Expose row format flags in KuduScanner ......................................................................
Expose row format flags in KuduScanner This adds a way to pass row format modifier flags to KuduScanner, encoded in an int64_t as a bitset. This API is marked as advanced and it's explicitely called out that the user is responsible for knowing the row data format that results from setting such flags and decoding the row data. The only use for these flags, presently, is to set PAD_UNIXTIME_MICROS_TO_16_BYTES, making sure that the server pads slots for UNIXTIME_MICROS with an additional 8 bytes to the left. In the future we might use these flags to (temporarily) provide old/new row formats without having to change all the row apis at once. This adds a new test to all_types-itest that tests reading data with the padding. The test scans a random projection to test the padded column(s) in different positions. Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Reviewed-on: http://gerrit.cloudera.org:8080/6624 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/scan_configuration.cc M src/kudu/client/scan_configuration.h M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h M src/kudu/integration-tests/all_types-itest.cc M src/kudu/tools/tool_action_remote_replica.cc M src/kudu/tserver/scanners-test.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/scanners.h M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver.proto 13 files changed, 387 insertions(+), 69 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
