Alexey Serbin has posted comments on this change. Change subject: Expose row format flags in KuduScanner ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6624/12/src/kudu/client/client.cc File src/kudu/client/client.cc: PS12, Line 1357: if (PREDICT_FALSE(data_->configuration().row_format_flags() != KuduScanner::NO_FLAGS)) { : return Status::IllegalState( : Substitute("Cannot extract rows. Row format modifier flags were selected: $0", : data_->configuration().row_format_flags())); : } If I'm not mistaken, to have that idempotent behavior Adar mentioned, it's necessary to place this before NextBatch() call. -- To view, visit http://gerrit.cloudera.org:8080/6624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I043b6514dc5fc307fc9c94eb41f3ae79796ba273 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
