Adar Dembo has posted comments on this change. Change subject: process_memory: incrementally track total process consumption ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6793/1//COMMIT_MSG Commit Message: PS1, Line 28: On the side, this changes process_memory to use GoogleOnce instead of : std::once. This sped up the microbenchmark significantly (almost 2x), : apparently due to better inlining. > my benchmark was on my ubuntu 16.04 laptop with libstdcxx/gcc Then I think we should strike std::once from the list of acceptable C++11 libraries and replace any existing calls with GoogleOnce, at least outside of unit tests. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/6793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3293110b7eda7f083bf400e165be3d782c441c49 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
