Adar Dembo has posted comments on this change. Change subject: process_memory: incrementally track total process consumption ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6793/1//COMMIT_MSG Commit Message: PS1, Line 28: On the side, this changes process_memory to use GoogleOnce instead of : std::once. This sped up the microbenchmark significantly (almost 2x), : apparently due to better inlining. > I don't think the other ones are perf-sensitive. I took a quick look at the existing instances and I agree that they're not perf-sensitive (the closest candidate is the one in InitKrb5Ctx, which I think is invoked on every connection negotiation). So I think whether it should be allowed depends on whether you think we'd notice its introduction in future perf-sensitive code, and suggesting GoogleOnce then. -- To view, visit http://gerrit.cloudera.org:8080/6793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3293110b7eda7f083bf400e165be3d782c441c49 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
