David Ribeiro Alves has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap ......................................................................
Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/5489/4/src/kudu/tablet/row_op.cc File src/kudu/tablet/row_op.cc: Line 56: DCHECK(!this->result) << this->result->DebugString(); > think we should leave this with SecureDebugString yeah this patch predates the secure stuff. Done http://gerrit.cloudera.org:8080/#/c/5489/4/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 251: // Plays operations, skipping those that have already been flushed. > can you clarify how it knows what is already flushed here? Not sure what you mean. I added a comment forwarding the reader to ApplyOperations, where that decision is actually made. PS4, Line 256: result > update Done Line 259: TxResultPB* new_result, > update docs to explain what it's filling in in new_result Done PS4, Line 1440: ShortDebugString > should use Secure form Done PS4, Line 1459: const OperationResultPB& new_op_result = new_result->ops(curr_op_idx); > this is only used down below inside the if block on L1491, right? maybe mov Done PS4, Line 1491: flushed > should we rename this PB field to 'skip_on_replay'? I think it would be mor Done PS4, Line 1519: already_flushed > also should maybe rename this field to "skip_replay"? Done -- To view, visit http://gerrit.cloudera.org:8080/5489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
