David Ribeiro Alves has posted comments on this change. Change subject: Fix bug in incorrect response rebuilding on tablet bootstrap ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5489/5/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS5, Line 264: const TxResultPB &orig_result, : TxResultPB *new_result, : WriteResponsePB *response, : bool *all_skipped); > nit: the *s and &s should go with the type, not the var Done PS5, Line 1259: const TxResultPB &orig_result, : TxResultPB *new_result, : WriteResponsePB *response, : bool *all_skipped) > style: same as above Done -- To view, visit http://gerrit.cloudera.org:8080/5489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1219ed5f7835e93cd7f3b128cedd650fc3384482 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
